Offering "main/flagship" incorrectly limited to one per line #16

New issue

Closed

opened 2026-08-27 19:56:49 +00:00 by Xeplosion · 0 comments

Xeplosion commented

2026-08-27 19:56:49 +00:00

Owner

What happened?

is_main_offering is meant to mark the flagship/most-emphasized offering on
a product line, but the schema description and the capture-form's own
validation both assert "at most one true per line" — enforced client-side
in tools/capture-form/index.html (mainCount > 1 check). In practice,
providers sometimes emphasize multiple offerings equally (e.g. two
co-featured "Most Popular" plans), which this incorrectly blocks/warns
against.

Steps to reproduce

Open a product line with 2+ offerings.
Mark two offerings as "main / flagship offering".
Capture-form's validation flags "more than one offering marked main —
pick at most one."

Expected behavior

Multiple offerings on the same line can be marked is_main_offering: true
when the provider's storefront genuinely emphasizes more than one.

Environment

No response

Additional context

No schema change needed — is_main_offering is a plain boolean with no
schema-level uniqueness constraint; the limit is purely the capture-form's
client-side check plus a misleading schema description string. Fix is:
remove the mainCount > 1 validation check, correct the schema description
("At most one true per line" -> drop that clause), and update
docs/capture-guide.md's matching guidance line.

Checklist

I have searched for existing issues before opening this one
I can reliably reproduce this
I have included enough detail to investigate

### What happened? is_main_offering is meant to mark the flagship/most-emphasized offering on a product line, but the schema description and the capture-form's own validation both assert "at most one true per line" — enforced client-side in tools/capture-form/index.html (mainCount > 1 check). In practice, providers sometimes emphasize multiple offerings equally (e.g. two co-featured "Most Popular" plans), which this incorrectly blocks/warns against. ### Steps to reproduce 1. Open a product line with 2+ offerings. 2. Mark two offerings as "main / flagship offering". 3. Capture-form's validation flags "more than one offering marked main — pick at most one." ### Expected behavior Multiple offerings on the same line can be marked is_main_offering: true when the provider's storefront genuinely emphasizes more than one. ### Environment _No response_ ### Additional context No schema change needed — is_main_offering is a plain boolean with no schema-level uniqueness constraint; the limit is purely the capture-form's client-side check plus a misleading schema description string. Fix is: remove the mainCount > 1 validation check, correct the schema description ("At most one true per line" -> drop that clause), and update docs/capture-guide.md's matching guidance line. ### Checklist - [x] I have searched for existing issues before opening this one - [x] I can reliably reproduce this - [x] I have included enough detail to investigate

Xeplosion closed this issue

2026-08-27 20:19:26 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

XeplosionGames/minecraft-provider-analysis#16

No description provided.

Rows
Columns